gavinchou commented on code in PR #58903:
URL: https://github.com/apache/doris/pull/58903#discussion_r2605670319
##########
be/src/io/cache/block_file_cache.cpp:
##########
@@ -56,6 +57,85 @@
namespace doris::io {
#include "common/compile_check_begin.h"
+// Insert a block pointer into one shard while swallowing allocation failures.
+bool NeedUpdateLRUBlocks::insert(FileBlockSPtr block) {
+ if (!block) {
+ return false;
+ }
+ try {
+ auto* raw_ptr = block.get();
+ auto idx = shard_index(raw_ptr);
+ auto& shard = _shards[idx];
+ std::lock_guard lock(shard.mutex);
+ auto [_, inserted] = shard.entries.emplace(raw_ptr, std::move(block));
+ if (inserted) {
+ _size.fetch_add(1, std::memory_order_relaxed);
+ }
+ return inserted;
+ } catch (const std::exception& e) {
+ LOG(WARNING) << "Failed to enqueue block for LRU update: " << e.what();
+ } catch (...) {
+ LOG(WARNING) << "Failed to enqueue block for LRU update: unknown
error";
+ }
+ return false;
+}
+
+// Drain up to `limit` unique blocks to the caller, keeping the structure
consistent on failures.
+size_t NeedUpdateLRUBlocks::drain(size_t limit, std::vector<FileBlockSPtr>*
output) {
+ if (limit == 0 || output == nullptr) {
+ return 0;
+ }
+ size_t drained = 0;
+ try {
+ output->reserve(output->size() + std::min(limit, size()));
+ for (auto& shard : _shards) {
+ if (drained >= limit) {
+ break;
+ }
+ std::lock_guard lock(shard.mutex);
Review Comment:
why not just "drain" the entire shard instead of draining one by one.
we dont actually care about the order here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
