yiguolei commented on code in PR #13795:
URL: https://github.com/apache/doris/pull/13795#discussion_r1009144221
##########
be/src/runtime/load_channel_mgr.h:
##########
@@ -80,7 +89,8 @@ class LoadChannelMgr {
Cache* _last_success_channel = nullptr;
// check the total load channel mem consumption of this Backend
- std::shared_ptr<MemTrackerLimiter> _mem_tracker;
+ std::unique_ptr<MemTracker> _mem_tracker;
Review Comment:
I think we should use MemTrackerLimiter here. Normal memtracker could be
used to control flush memtable. But if it could not flush memtable accurately
then limiter memtracker will work. If this is a normal memtracker, OOM will
occurred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
