yujun777 commented on code in PR #58683:
URL: https://github.com/apache/doris/pull/58683#discussion_r2587298339
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/analyzer/Scope.java:
##########
@@ -82,13 +83,17 @@ public Scope(List<Slot> slots, List<Slot> asteriskSlots) {
/** Scope */
public Scope(Optional<Scope> outerScope, List<Slot> slots, List<Slot>
asteriskSlots) {
this.outerScope = Objects.requireNonNull(outerScope, "outerScope can
not be null");
- this.slots = Utils.fastToImmutableList(Objects.requireNonNull(slots,
"slots can not be null"));
+ this.slots = Utils.fastToImmutableList(Objects.requireNonNull(
Review Comment:
change this.slot / this.asteriskSlots to Set, this.slots =
Utils.fastToImmutableSet ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
