yiguolei commented on code in PR #58582:
URL: https://github.com/apache/doris/pull/58582#discussion_r2587106939
##########
be/src/olap/accept_null_predicate.h:
##########
@@ -40,8 +40,30 @@ class AcceptNullPredicate : public ColumnPredicate {
ENABLE_FACTORY_CREATOR(AcceptNullPredicate);
public:
- AcceptNullPredicate(ColumnPredicate* nested)
- : ColumnPredicate(nested->column_id(), nested->opposite()),
_nested {nested} {}
+ AcceptNullPredicate(std::shared_ptr<ColumnPredicate> nested)
Review Comment:
这里传递const 引用好一些，能减少shared ptr 的copy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
