dataroaring commented on code in PR #13359:
URL: https://github.com/apache/doris/pull/13359#discussion_r1009070950
##########
be/src/olap/compaction.cpp:
##########
@@ -112,14 +113,50 @@ Status Compaction::quick_rowsets_compact() {
Status Compaction::do_compaction(int64_t permits) {
TRACE("start to do compaction");
+ uint32_t checksum_before;
+ uint32_t checksum_after;
+ if (config::enable_compaction_checksum) {
+ EngineChecksumTask checksum_task(_tablet->tablet_id(),
_tablet->schema_hash(),
+ _input_rowsets.back()->end_version(),
&checksum_before);
+ checksum_task.execute();
+ }
+
_tablet->data_dir()->disks_compaction_score_increment(permits);
_tablet->data_dir()->disks_compaction_num_increment(1);
Status st = do_compaction_impl(permits);
_tablet->data_dir()->disks_compaction_score_increment(-permits);
_tablet->data_dir()->disks_compaction_num_increment(-1);
+
+ if (config::enable_compaction_checksum) {
+ EngineChecksumTask checksum_task(_tablet->tablet_id(),
_tablet->schema_hash(),
Review Comment:
EngineChecksumTask does not do merge for unique key, so it does not work for
now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
