freemandealer commented on code in PR #12866:
URL: https://github.com/apache/doris/pull/12866#discussion_r1008698285
##########
be/src/olap/rowset/beta_rowset_writer.cpp:
##########
@@ -236,6 +692,26 @@ RowsetSharedPtr BetaRowsetWriter::build() {
return nullptr;
}
}
+ Status status;
+ status = _wait_flying_segcompaction();
+ if (!status.ok()) {
+ LOG(WARNING) << "segcompaction failed when build new rowset, res=" <<
status;
+ return nullptr;
+ }
+ status = _segcompaction_ramaining_if_necessary();
+ if (!status.ok()) {
+ LOG(WARNING) << "segcompaction failed when build new rowset, res=" <<
status;
Review Comment:
Theoretically, it should not. Non-deadly failures are handled as need-retry.
Here is the the last-ditch for the remaining failures that is hard to handle by
simply retrying.
Eliminating them is hard but not impossible, as long as more effort had been
made. I think we can polish them up in future patches if it causes any real
problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
