morrySnow commented on code in PR #13740:
URL: https://github.com/apache/doris/pull/13740#discussion_r1007880004
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/GroupExpression.java:
##########
@@ -231,13 +231,14 @@ public boolean equals(Object o) {
if (plan instanceof UnboundRelation) {
return false;
}
+ // TODO: reconsider children, because children is mutable.
return children.equals(that.children) && plan.equals(that.plan)
&&
plan.getLogicalProperties().equals(that.plan.getLogicalProperties());
}
@Override
public int hashCode() {
- return Objects.hash(children, plan);
Review Comment:
add children back
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
