morningman commented on code in PR #13746: URL: https://github.com/apache/doris/pull/13746#discussion_r1007527277
########## fe/fe-core/src/main/java/org/apache/doris/qe/MasterCatalogExecutor.java: ########## @@ -0,0 +1,76 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +package org.apache.doris.qe; + +import org.apache.doris.common.ClientPool; +import org.apache.doris.thrift.FrontendService; +import org.apache.doris.thrift.TInitExternalCtlMetaRequest; +import org.apache.doris.thrift.TInitExternalCtlMetaResult; +import org.apache.doris.thrift.TNetworkAddress; + +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; + +public class MasterCatalogExecutor { Review Comment: Add some comment for this class ########## gensrc/thrift/FrontendService.thrift: ########## @@ -678,6 +678,17 @@ struct TWaitingTxnStatusResult { 2: optional i32 txn_status_id } +struct TInitExternalCtlMetaRequest { + 1: optional string catalogName + 2: optional string dbName + 3: optional string tableName +} + +struct TInitExternalCtlMetaResult { + 1: required i64 maxJournalId; Review Comment: ```suggestion 1: optional i64 maxJournalId; ``` ########## fe/fe-core/src/main/java/org/apache/doris/datasource/HMSExternalCatalog.java: ########## @@ -105,10 +106,24 @@ private void init() { * Catalog can't be init when creating because the external catalog may depend on third system. * So you have to make sure the client of third system is initialized before any method was called. */ - private synchronized void makeSureInitialized() { + @Override + public synchronized void makeSureInitialized() { if (!initialized) { + if (!Env.getCurrentEnv().isMaster()) { + // Forward to master and wait the journal to replay. + MasterCatalogExecutor remoteExecutor = new MasterCatalogExecutor(); + try { + remoteExecutor.forward(name, null, null); + } catch (Exception e) { + LOG.warn("Failed to forward init operation to master. {}", e.getMessage()); + } + return; + } init(); initialized = true; + ExternalObjectInitLog log = new ExternalObjectInitLog(); Review Comment: Missing database info? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org
