eldenmoon commented on code in PR #58107:
URL: https://github.com/apache/doris/pull/58107#discussion_r2540396704
##########
be/src/vec/exec/format/json/new_json_reader.cpp:
##########
@@ -1065,7 +1068,15 @@ Status
NewJsonReader::_simdjson_write_data_to_column(simdjson::ondemand::value&
auto primitive_type = type_desc->get_primitive_type();
if (_is_load || !is_complex_type(primitive_type)) {
if (value.type() == simdjson::ondemand::json_type::string) {
- std::string_view value_string = value.get_string();
+ const auto cache_key = value.raw_json().value();
+ std::string_view value_string;
+ if (_cached_string_values.contains(cache_key)) {
Review Comment:
map will lead to performance issue, and this is the critical part.maybe
only modify _simdjson_write_columns_by_jsonpath
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
