eldenmoon commented on code in PR #57702:
URL: https://github.com/apache/doris/pull/57702#discussion_r2536490777


##########
be/src/olap/rowset/segment_v2/vertical_segment_writer.cpp:
##########
@@ -1344,6 +1345,17 @@ Status VerticalSegmentWriter::_write_primary_key_index() 
{
 Status VerticalSegmentWriter::_write_footer() {
     _footer.set_num_rows(_row_count);
 
+    // Decide whether to externalize ColumnMetaPB by tablet default, and stamp 
footer version
+    DCHECK(_tablet != nullptr);
+    const bool enable_external_col_meta =
+            _tablet->tablet_meta()->is_external_segment_meta_used_default();

Review Comment:
   或者放到tablet schema中



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to