englefly commented on code in PR #13600:
URL: https://github.com/apache/doris/pull/13600#discussion_r1004058783


##########
regression-test/suites/correctness/test_pushdown_pred_to_view.groovy:
##########
@@ -54,7 +54,7 @@ The same resolve error occurs when re-analyze v2.
      """
 
      qt_sql """
-         select * from ${viewName} as v1 join ${viewName} as v2 on v1.id=v2.id 
and v1.id>0;
+         select * from ${viewName} as v1 join ${viewName} as v2 where 
v1.id=v2.id and v1.id>0;

Review Comment:
   it is better to add another test case for `join ... on` after we fixed the 
second bug.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to