This is an automated email from the ASF dual-hosted git repository.
yiguolei pushed a commit to branch branch-1.1-lts
in repository https://gitbox.apache.org/repos/asf/doris.git
The following commit(s) were added to refs/heads/branch-1.1-lts by this push:
new 45bed60a89 [fix](rowset) fix that rowset writer doesn't process the
return value, which may result in data loss (#13224)
45bed60a89 is described below
commit 45bed60a8967fae34dc10a9b4c88738de2694520
Author: Xin Liao <liaoxin...@126.com>
AuthorDate: Fri Oct 21 17:42:04 2022 +0800
[fix](rowset) fix that rowset writer doesn't process the return value,
which may result in data loss (#13224)
---
be/src/olap/rowset/beta_rowset_writer.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/be/src/olap/rowset/beta_rowset_writer.cpp
b/be/src/olap/rowset/beta_rowset_writer.cpp
index 3cfeb27091..e6c0ba6d38 100644
--- a/be/src/olap/rowset/beta_rowset_writer.cpp
+++ b/be/src/olap/rowset/beta_rowset_writer.cpp
@@ -173,7 +173,11 @@ OLAPStatus
BetaRowsetWriter::flush_single_memtable(MemTable* memtable, int64_t*
RowsetSharedPtr BetaRowsetWriter::build() {
// TODO(lingbin): move to more better place, or in a CreateBlockBatch?
for (auto& wblock : _wblocks) {
- wblock->close();
+ Status status = wblock->close();
+ if (!status.ok()) {
+ LOG(WARNING) << "failed to close wblock, res=" << status;
+ return nullptr;
+ }
}
// When building a rowset, we must ensure that the current _segment_writer
has been
// flushed, that is, the current _segment_writer is nullptr
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
