github-actions[bot] commented on PR #13532:
URL: https://github.com/apache/doris/pull/13532#issuecomment-1286090777
#### `sh-checker report`
To get the full details, please check in the
[job]("https://github.com/apache/doris/actions/runs/3290787716";) output.
<details>
<summary>shellcheck errors</summary>
```
'shellcheck ' returned error 1 finding the following syntactical issues:
----------
In regression-test/pipeline/P0/generate_cluster_conf.sh line 4:
ip=$(ifconfig -a|grep inet|grep -v 127.0.0.1|grep -v inet6|awk '{print
$2}'|tr -d "addr:"|tail -n +${eth0_num}|head -n 1)
^-----^ SC2020 (info): tr replaces sets of chars, not words (mentioned due
to duplicates).
^---------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
ip=$(ifconfig -a|grep inet|grep -v 127.0.0.1|grep -v inet6|awk '{print
$2}'|tr -d "addr:"|tail -n +"${eth0_num}"|head -n 1)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 6:
start=1
^---^ SC2034 (warning): start appears unused. Verify use (or export if used
externally).
In regression-test/pipeline/P0/generate_cluster_conf.sh line 7:
end=1
^-^ SC2034 (warning): end appears unused. Verify use (or export if used
externally).
In regression-test/pipeline/P0/generate_cluster_conf.sh line 25:
if [ ! -d Cluster$i ];then
^----------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^-- SC2086 (info): Double quote to prevent globbing and
word splitting.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ ! -d Cluster"$i" ]];then
In regression-test/pipeline/P0/generate_cluster_conf.sh line 27:
cp -r template_cluster_conf Cluster$i
^-- SC2086 (info): Double quote
to prevent globbing and word splitting.
^-- SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cp -r template_cluster_conf Cluster"$i"
In regression-test/pipeline/P0/generate_cluster_conf.sh line 28:
mkdir -p ../../clusterRegressionCenter/${case_level}/Cluster$i
^-----------^ SC2248 (style):
Prefer double quoting even when variables don't contain special characters.
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
mkdir -p ../../clusterRegressionCenter/"${case_level}"/Cluster"$i"
In regression-test/pipeline/P0/generate_cluster_conf.sh line 30:
add_num=`expr $i \* 100`
^--------------^ SC2006 (style): Use $(...) notation instead
of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting
this using $((..)), ${} or [[ ]].
^-- SC2086 (info): Double quote to prevent globbing
and word splitting.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
add_num=$(expr "$i" \* 100)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 31:
be_port=`expr $base_be_port + $add_num`
^-----------------------------^ SC2006 (style): Use $(...)
notation instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting
this using $((..)), ${} or [[ ]].
^-----------^ SC2248 (style): Prefer double quoting
even when variables don't contain special characters.
^-----------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
be_port=$(expr "$base_be_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 32:
webserver_port=`expr $base_webserver_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of
legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^------------------^ SC2248 (style): Prefer
double quoting even when variables don't contain special characters.
^------------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
webserver_port=$(expr "$base_webserver_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 33:
heartbeat_service_port=`expr $base_heartbeat_service_port + $add_num`
^-- SC2006 (style): Use $(...) notation
instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated.
Consider rewriting this using $((..)), ${} or [[ ]].
^--------------------------^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^--------------------------^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------^
SC2086 (info): Double quote to prevent globbing and word splitting.
^------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
heartbeat_service_port=$(expr "$base_heartbeat_service_port" +
$add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 34:
brpc_port=`expr $base_brpc_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^-------------^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^-------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
brpc_port=$(expr "$base_brpc_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 35:
sed -i 's/be_port = 9060/be_port = '"${be_port}"'/g'
Cluster$i/conf/be.conf
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/be_port = 9060/be_port = '"${be_port}"'/g'
Cluster"$i"/conf/be.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 36:
sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster$i/conf/be.conf
^-- SC2086 (info): Double quote to prevent globbing and word
splitting.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster"$i"/conf/be.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 37:
sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster$i/conf/be.conf
^-- SC2086 (info): Double quote to prevent
globbing and word splitting.
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster"$i"/conf/be.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 38:
sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster$i/conf/be.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster"$i"/conf/be.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 39:
sed -i 's/cluster0/cluster'"$i"'/g' Cluster$i/conf/be.conf
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-- SC2086 (info): Double
quote to prevent globbing and word splitting.
^-- SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
sed -i 's/cluster0/cluster'"${i}"'/g' Cluster"$i"/conf/be.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 44:
http_port=`expr $base_http_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^-------------^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^-------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
http_port=$(expr "$base_http_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 45:
rpc_port=`expr $base_rpc_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^------------^ SC2248 (style): Prefer double quoting
even when variables don't contain special characters.
^------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
rpc_port=$(expr "$base_rpc_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 46:
query_port=`expr $base_query_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^--------------^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^--------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
query_port=$(expr "$base_query_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 47:
edit_log_port=`expr $base_edit_log_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of
legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^-----------------^ SC2248 (style): Prefer
double quoting even when variables don't contain special characters.
^-----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
edit_log_port=$(expr "$base_edit_log_port" + $add_num)
In regression-test/pipeline/P0/generate_cluster_conf.sh line 48:
sed -i 's/http_port = 8030/http_port = '"${http_port}"'/g'
Cluster$i/conf/fe.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/http_port = 8030/http_port = '"${http_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 49:
sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster$i/conf/fe.conf
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 50:
sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster$i/conf/fe.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 51:
sed -i 's/edit_log_port = 9010/edit_log_port = '"${edit_log_port}"'/g'
Cluster$i/conf/fe.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
sed -i 's/edit_log_port = 9010/edit_log_port = '"${edit_log_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P0/generate_cluster_conf.sh line 54:
sed -i 's/127.0.0.1:9030/'"${ip}"':'"${query_port}"'/g'
Cluster$i/conf/regression-conf.groovy
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/127.0.0.1:9030/'"${ip}"':'"${query_port}"'/g'
Cluster"$i"/conf/regression-conf.groovy
In regression-test/pipeline/P0/generate_cluster_conf.sh line 55:
sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster$i/conf/regression-conf.groovy
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster"$i"/conf/regression-conf.groovy
In regression-test/pipeline/P0/generate_cluster_conf.sh line 56:
sed -i 's/127.0.0.1:8040/'"${ip}"':'"${webserver_port}"'/g'
Cluster$i/conf/regression-conf.groovy
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/127.0.0.1:8040/'"${ip}"':'"${webserver_port}"'/g'
Cluster"$i"/conf/regression-conf.groovy
In regression-test/pipeline/P0/generate_cluster_conf.sh line 59:
echo "root@${ip}" > Cluster$i/be_hosts
^-- SC2086 (info): Double quote to
prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo "root@${ip}" > Cluster"$i"/be_hosts
In regression-test/pipeline/P0/generate_cluster_conf.sh line 60:
echo "root@${ip}" > Cluster$i/fe_hosts
^-- SC2086 (info): Double quote to
prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo "root@${ip}" > Cluster"$i"/fe_hosts
In regression-test/pipeline/P1/generate_cluster_conf.sh line 4:
ip=$(ifconfig -a|grep inet|grep -v 127.0.0.1|grep -v inet6|awk '{print
$2}'|tr -d "addr:"|tail -n +${eth0_num}|head -n 1)
^-----^ SC2020 (info): tr replaces sets of chars, not words (mentioned due
to duplicates).
^---------^ SC2086 (info): Double quote to prevent
globbing and word splitting.
Did you mean:
ip=$(ifconfig -a|grep inet|grep -v 127.0.0.1|grep -v inet6|awk '{print
$2}'|tr -d "addr:"|tail -n +"${eth0_num}"|head -n 1)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 6:
start=1
^---^ SC2034 (warning): start appears unused. Verify use (or export if used
externally).
In regression-test/pipeline/P1/generate_cluster_conf.sh line 7:
end=1
^-^ SC2034 (warning): end appears unused. Verify use (or export if used
externally).
In regression-test/pipeline/P1/generate_cluster_conf.sh line 21:
case_level=P1
^--------^ SC2034 (warning): case_level appears unused. Verify use (or
export if used externally).
In regression-test/pipeline/P1/generate_cluster_conf.sh line 25:
if [ ! -d Cluster$i ];then
^----------------^ SC2292 (style): Prefer [[ ]] over [ ] for tests in
Bash/Ksh.
^-- SC2086 (info): Double quote to prevent globbing and
word splitting.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
if [[ ! -d Cluster"$i" ]];then
In regression-test/pipeline/P1/generate_cluster_conf.sh line 27:
cp -r template_cluster_conf Cluster$i
^-- SC2086 (info): Double quote
to prevent globbing and word splitting.
^-- SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
cp -r template_cluster_conf Cluster"$i"
In regression-test/pipeline/P1/generate_cluster_conf.sh line 28:
mkdir -p ../../clusterRegressionCenter/P1/Cluster$i
^-- SC2086 (info):
Double quote to prevent globbing and word splitting.
^-- SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
mkdir -p ../../clusterRegressionCenter/P1/Cluster"$i"
In regression-test/pipeline/P1/generate_cluster_conf.sh line 30:
add_num=`expr $i \* 100`
^--------------^ SC2006 (style): Use $(...) notation instead
of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting
this using $((..)), ${} or [[ ]].
^-- SC2086 (info): Double quote to prevent globbing
and word splitting.
^-- SC2250 (style): Prefer putting braces around
variable references even when not strictly required.
Did you mean:
add_num=$(expr "$i" \* 100)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 31:
be_port=`expr $base_be_port + $add_num`
^-----------------------------^ SC2006 (style): Use $(...)
notation instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider rewriting
this using $((..)), ${} or [[ ]].
^-----------^ SC2248 (style): Prefer double quoting
even when variables don't contain special characters.
^-----------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
be_port=$(expr "$base_be_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 32:
webserver_port=`expr $base_webserver_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of
legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^------------------^ SC2248 (style): Prefer
double quoting even when variables don't contain special characters.
^------------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
webserver_port=$(expr "$base_webserver_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 33:
heartbeat_service_port=`expr $base_heartbeat_service_port + $add_num`
^-- SC2006 (style): Use $(...) notation
instead of legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated.
Consider rewriting this using $((..)), ${} or [[ ]].
^--------------------------^ SC2248
(style): Prefer double quoting even when variables don't contain special
characters.
^--------------------------^ SC2250
(style): Prefer putting braces around variable references even when not
strictly required.
^------^
SC2086 (info): Double quote to prevent globbing and word splitting.
^------^
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
heartbeat_service_port=$(expr "$base_heartbeat_service_port" +
$add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 34:
brpc_port=`expr $base_brpc_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^-------------^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^-------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
brpc_port=$(expr "$base_brpc_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 35:
sed -i 's/be_port = 9060/be_port = '"${be_port}"'/g'
Cluster$i/conf/be.conf
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/be_port = 9060/be_port = '"${be_port}"'/g'
Cluster"$i"/conf/be.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 36:
sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster$i/conf/be.conf
^-- SC2086 (info): Double quote to prevent globbing and word
splitting.
^-- SC2250 (style): Prefer putting braces around variable
references even when not strictly required.
Did you mean:
sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster"$i"/conf/be.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 37:
sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster$i/conf/be.conf
^-- SC2086 (info): Double quote to prevent
globbing and word splitting.
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster"$i"/conf/be.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 38:
sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster$i/conf/be.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster"$i"/conf/be.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 39:
sed -i 's/cluster0/cluster'"$i"'/g' Cluster$i/conf/be.conf
^-- SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^-- SC2086 (info): Double
quote to prevent globbing and word splitting.
^-- SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
sed -i 's/cluster0/cluster'"${i}"'/g' Cluster"$i"/conf/be.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 44:
http_port=`expr $base_http_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^-------------^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^-------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
http_port=$(expr "$base_http_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 45:
rpc_port=`expr $base_rpc_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^------------^ SC2248 (style): Prefer double quoting
even when variables don't contain special characters.
^------------^ SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
^------^ SC2086 (info): Double quote
to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
rpc_port=$(expr "$base_rpc_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 46:
query_port=`expr $base_query_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of legacy
backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^--------------^ SC2248 (style): Prefer double
quoting even when variables don't contain special characters.
^--------------^ SC2250 (style): Prefer putting
braces around variable references even when not strictly required.
^------^ SC2086 (info): Double
quote to prevent globbing and word splitting.
^------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
Did you mean:
query_port=$(expr "$base_query_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 47:
edit_log_port=`expr $base_edit_log_port + $add_num`
^-- SC2006 (style): Use $(...) notation instead of
legacy backticks `...`.
^--^ SC2003 (style): expr is antiquated. Consider
rewriting this using $((..)), ${} or [[ ]].
^-----------------^ SC2248 (style): Prefer
double quoting even when variables don't contain special characters.
^-----------------^ SC2250 (style): Prefer
putting braces around variable references even when not strictly required.
^------^ SC2086 (info):
Double quote to prevent globbing and word splitting.
^------^ SC2250 (style):
Prefer putting braces around variable references even when not strictly
required.
Did you mean:
edit_log_port=$(expr "$base_edit_log_port" + $add_num)
In regression-test/pipeline/P1/generate_cluster_conf.sh line 48:
sed -i 's/http_port = 8030/http_port = '"${http_port}"'/g'
Cluster$i/conf/fe.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/http_port = 8030/http_port = '"${http_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 49:
sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster$i/conf/fe.conf
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 50:
sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster$i/conf/fe.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 51:
sed -i 's/edit_log_port = 9010/edit_log_port = '"${edit_log_port}"'/g'
Cluster$i/conf/fe.conf
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references
even when not strictly required.
Did you mean:
sed -i 's/edit_log_port = 9010/edit_log_port = '"${edit_log_port}"'/g'
Cluster"$i"/conf/fe.conf
In regression-test/pipeline/P1/generate_cluster_conf.sh line 54:
sed -i 's/127.0.0.1:9030/'"${ip}"':'"${query_port}"'/g'
Cluster$i/conf/regression-conf.groovy
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/127.0.0.1:9030/'"${ip}"':'"${query_port}"'/g'
Cluster"$i"/conf/regression-conf.groovy
In regression-test/pipeline/P1/generate_cluster_conf.sh line 55:
sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster$i/conf/regression-conf.groovy
^--
SC2086 (info): Double quote to prevent globbing and word splitting.
^--
SC2250 (style): Prefer putting braces around variable references even when not
strictly required.
Did you mean:
sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster"$i"/conf/regression-conf.groovy
In regression-test/pipeline/P1/generate_cluster_conf.sh line 56:
sed -i 's/127.0.0.1:8040/'"${ip}"':'"${webserver_port}"'/g'
Cluster$i/conf/regression-conf.groovy
^-- SC2086 (info): Double quote to prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces around variable references even when
not strictly required.
Did you mean:
sed -i 's/127.0.0.1:8040/'"${ip}"':'"${webserver_port}"'/g'
Cluster"$i"/conf/regression-conf.groovy
In regression-test/pipeline/P1/generate_cluster_conf.sh line 59:
echo "root@${ip}" > Cluster$i/be_hosts
^-- SC2086 (info): Double quote to
prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo "root@${ip}" > Cluster"$i"/be_hosts
In regression-test/pipeline/P1/generate_cluster_conf.sh line 60:
echo "root@${ip}" > Cluster$i/fe_hosts
^-- SC2086 (info): Double quote to
prevent globbing and word splitting.
^-- SC2250 (style): Prefer putting braces
around variable references even when not strictly required.
Did you mean:
echo "root@${ip}" > Cluster"$i"/fe_hosts
For more information:
https://www.shellcheck.net/wiki/SC2034 -- case_level appears unused.
Verify...
https://www.shellcheck.net/wiki/SC2020 -- tr replaces sets of chars, not
wo...
https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing
...
----------
You can address the above issues in one of three ways:
1. Manually correct the issue in the offending shell script;
2. Disable specific issues by adding the comment:
# shellcheck disable=NNNN
above the line that contains the issue, where NNNN is the error code;
3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file.
```
</details>
<details>
<summary>shfmt errors</summary>
```
'shfmt ' returned error 1 finding the following formatting issues:
----------
--- regression-test/pipeline/P0/generate_cluster_conf.sh.orig
+++ regression-test/pipeline/P0/generate_cluster_conf.sh
@@ -1,7 +1,7 @@
#!/bin/bash
-eth0_num=$(ifconfig -a|grep flags=|grep -n eth0|awk -F ':' '{print $1}')
-ip=$(ifconfig -a|grep inet|grep -v 127.0.0.1|grep -v inet6|awk '{print
$2}'|tr -d "addr:"|tail -n +${eth0_num}|head -n 1)
+eth0_num=$(ifconfig -a | grep flags= | grep -n eth0 | awk -F ':' '{print
$1}')
+ip=$(ifconfig -a | grep inet | grep -v 127.0.0.1 | grep -v inet6 | awk
'{print $2}' | tr -d "addr:" | tail -n +${eth0_num} | head -n 1)
start=1
end=1
@@ -20,46 +20,43 @@
case_level=P0
-for i in $(seq 0 7)
-do
- if [ ! -d Cluster$i ];then
-
- cp -r template_cluster_conf Cluster$i
- mkdir -p ../../clusterRegressionCenter/${case_level}/Cluster$i
+for i in $(seq 0 7); do
+ if [ ! -d Cluster$i ]; then
+
+ cp -r template_cluster_conf Cluster$i
+ mkdir -p ../../clusterRegressionCenter/${case_level}/Cluster$i
#modify fe port
- add_num=`expr $i \* 100`
- be_port=`expr $base_be_port + $add_num`
- webserver_port=`expr $base_webserver_port + $add_num`
- heartbeat_service_port=`expr $base_heartbeat_service_port +
$add_num`
- brpc_port=`expr $base_brpc_port + $add_num`
+ add_num=$(expr $i \* 100)
+ be_port=$(expr $base_be_port + $add_num)
+ webserver_port=$(expr $base_webserver_port + $add_num)
+ heartbeat_service_port=$(expr $base_heartbeat_service_port +
$add_num)
+ brpc_port=$(expr $base_brpc_port + $add_num)
sed -i 's/be_port = 9060/be_port = '"${be_port}"'/g'
Cluster$i/conf/be.conf
- sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster$i/conf/be.conf
- sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster$i/conf/be.conf
- sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster$i/conf/be.conf
+ sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster$i/conf/be.conf
+ sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster$i/conf/be.conf
+ sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster$i/conf/be.conf
sed -i 's/cluster0/cluster'"$i"'/g' Cluster$i/conf/be.conf
+ #modify be port
- #modify be port
-
- http_port=`expr $base_http_port + $add_num`
- rpc_port=`expr $base_rpc_port + $add_num`
- query_port=`expr $base_query_port + $add_num`
- edit_log_port=`expr $base_edit_log_port + $add_num`
+ http_port=$(expr $base_http_port + $add_num)
+ rpc_port=$(expr $base_rpc_port + $add_num)
+ query_port=$(expr $base_query_port + $add_num)
+ edit_log_port=$(expr $base_edit_log_port + $add_num)
sed -i 's/http_port = 8030/http_port = '"${http_port}"'/g'
Cluster$i/conf/fe.conf
- sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster$i/conf/fe.conf
- sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster$i/conf/fe.conf
- sed -i 's/edit_log_port = 9010/edit_log_port = '"${edit_log_port}"'/g'
Cluster$i/conf/fe.conf
+ sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster$i/conf/fe.conf
+ sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster$i/conf/fe.conf
+ sed -i 's/edit_log_port = 9010/edit_log_port =
'"${edit_log_port}"'/g' Cluster$i/conf/fe.conf
- #modify regression groovy conf
+ #modify regression groovy conf
sed -i 's/127.0.0.1:9030/'"${ip}"':'"${query_port}"'/g'
Cluster$i/conf/regression-conf.groovy
- sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster$i/conf/regression-conf.groovy
+ sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster$i/conf/regression-conf.groovy
sed -i 's/127.0.0.1:8040/'"${ip}"':'"${webserver_port}"'/g'
Cluster$i/conf/regression-conf.groovy
#generate be_hosts and fe_hosts
- echo "root@${ip}" > Cluster$i/be_hosts
- echo "root@${ip}" > Cluster$i/fe_hosts
+ echo "root@${ip}" >Cluster$i/be_hosts
+ echo "root@${ip}" >Cluster$i/fe_hosts
fi
-
done
--- regression-test/pipeline/P1/generate_cluster_conf.sh.orig
+++ regression-test/pipeline/P1/generate_cluster_conf.sh
@@ -1,7 +1,7 @@
#!/bin/bash
-eth0_num=$(ifconfig -a|grep flags=|grep -n eth0|awk -F ':' '{print $1}')
-ip=$(ifconfig -a|grep inet|grep -v 127.0.0.1|grep -v inet6|awk '{print
$2}'|tr -d "addr:"|tail -n +${eth0_num}|head -n 1)
+eth0_num=$(ifconfig -a | grep flags= | grep -n eth0 | awk -F ':' '{print
$1}')
+ip=$(ifconfig -a | grep inet | grep -v 127.0.0.1 | grep -v inet6 | awk
'{print $2}' | tr -d "addr:" | tail -n +${eth0_num} | head -n 1)
start=1
end=1
@@ -20,46 +20,43 @@
case_level=P1
-for i in $(seq 0 7)
-do
- if [ ! -d Cluster$i ];then
-
- cp -r template_cluster_conf Cluster$i
- mkdir -p ../../clusterRegressionCenter/P1/Cluster$i
+for i in $(seq 0 7); do
+ if [ ! -d Cluster$i ]; then
+
+ cp -r template_cluster_conf Cluster$i
+ mkdir -p ../../clusterRegressionCenter/P1/Cluster$i
#modify fe port
- add_num=`expr $i \* 100`
- be_port=`expr $base_be_port + $add_num`
- webserver_port=`expr $base_webserver_port + $add_num`
- heartbeat_service_port=`expr $base_heartbeat_service_port +
$add_num`
- brpc_port=`expr $base_brpc_port + $add_num`
+ add_num=$(expr $i \* 100)
+ be_port=$(expr $base_be_port + $add_num)
+ webserver_port=$(expr $base_webserver_port + $add_num)
+ heartbeat_service_port=$(expr $base_heartbeat_service_port +
$add_num)
+ brpc_port=$(expr $base_brpc_port + $add_num)
sed -i 's/be_port = 9060/be_port = '"${be_port}"'/g'
Cluster$i/conf/be.conf
- sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster$i/conf/be.conf
- sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster$i/conf/be.conf
- sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster$i/conf/be.conf
+ sed -i 's/webserver_port = 8040/webserver_port =
'"${webserver_port}"'/g' Cluster$i/conf/be.conf
+ sed -i 's/heartbeat_service_port = 9050/heartbeat_service_port =
'"${heartbeat_service_port}"'/g' Cluster$i/conf/be.conf
+ sed -i 's/brpc_port = 8060/brpc_port = '"${brpc_port}"'/g'
Cluster$i/conf/be.conf
sed -i 's/cluster0/cluster'"$i"'/g' Cluster$i/conf/be.conf
+ #modify be port
- #modify be port
-
- http_port=`expr $base_http_port + $add_num`
- rpc_port=`expr $base_rpc_port + $add_num`
- query_port=`expr $base_query_port + $add_num`
- edit_log_port=`expr $base_edit_log_port + $add_num`
+ http_port=$(expr $base_http_port + $add_num)
+ rpc_port=$(expr $base_rpc_port + $add_num)
+ query_port=$(expr $base_query_port + $add_num)
+ edit_log_port=$(expr $base_edit_log_port + $add_num)
sed -i 's/http_port = 8030/http_port = '"${http_port}"'/g'
Cluster$i/conf/fe.conf
- sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster$i/conf/fe.conf
- sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster$i/conf/fe.conf
- sed -i 's/edit_log_port = 9010/edit_log_port = '"${edit_log_port}"'/g'
Cluster$i/conf/fe.conf
+ sed -i 's/rpc_port = 9020/rpc_port = '"${rpc_port}"'/g'
Cluster$i/conf/fe.conf
+ sed -i 's/query_port = 9030/query_port = '"${query_port}"'/g'
Cluster$i/conf/fe.conf
+ sed -i 's/edit_log_port = 9010/edit_log_port =
'"${edit_log_port}"'/g' Cluster$i/conf/fe.conf
- #modify regression groovy conf
+ #modify regression groovy conf
sed -i 's/127.0.0.1:9030/'"${ip}"':'"${query_port}"'/g'
Cluster$i/conf/regression-conf.groovy
- sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster$i/conf/regression-conf.groovy
+ sed -i 's/127.0.0.1:8030/'"${ip}"':'"${http_port}"'/g'
Cluster$i/conf/regression-conf.groovy
sed -i 's/127.0.0.1:8040/'"${ip}"':'"${webserver_port}"'/g'
Cluster$i/conf/regression-conf.groovy
#generate be_hosts and fe_hosts
- echo "root@${ip}" > Cluster$i/be_hosts
- echo "root@${ip}" > Cluster$i/fe_hosts
+ echo "root@${ip}" >Cluster$i/be_hosts
+ echo "root@${ip}" >Cluster$i/fe_hosts
fi
-
done
----------
You can reformat the above files to meet shfmt's requirements by typing:
shfmt -w filename
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
