[GitHub] [doris] BiteTheDDDDt commented on a diff in pull request #13466: [function](date_function)add new date function 'last_day'

[GitBox]

BiteTheDDDDt commented on code in PR #13466:
URL: https://github.com/apache/doris/pull/13466#discussion_r1000089198


##########
be/src/vec/functions/function_timestamp.cpp:
##########
@@ -619,6 +764,14 @@ void register_function_timestamp(SimpleFunctionFactory& 
factory) {
     factory.register_function<
             
FunctionUnixTimestamp<UnixTimeStampDatetimeImpl<DataTypeDateTimeV2>>>();
     factory.register_function<FunctionUnixTimestamp<UnixTimeStampStrImpl>>();
+    factory.register_function<
+            FunctionDateOrDateTimeToDate<LastDayImpl<DataTypeDateTime>, 
DataTypeDateTime>>();

Review Comment:
   Maybe we have some way to avoid passing two same template parameters



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org