HappenLee commented on code in PR #13166:
URL: https://github.com/apache/doris/pull/13166#discussion_r999095618
##########
be/src/exec/olap_common.h:
##########
@@ -508,45 +511,62 @@ size_t
ColumnValueRange<primitive_type>::get_convertible_fixed_value_size() cons
return _high_value - _low_value;
}
-template <>
-void ColumnValueRange<PrimitiveType::TYPE_STRING>::convert_to_fixed_value();
-
-template <>
-void ColumnValueRange<PrimitiveType::TYPE_CHAR>::convert_to_fixed_value();
-
-template <>
-void ColumnValueRange<PrimitiveType::TYPE_VARCHAR>::convert_to_fixed_value();
-
-template <>
-void ColumnValueRange<PrimitiveType::TYPE_HLL>::convert_to_fixed_value();
-
-template <>
-void ColumnValueRange<PrimitiveType::TYPE_DECIMALV2>::convert_to_fixed_value();
+template <PrimitiveType primitive_type>
+bool ColumnValueRange<primitive_type>::convert_to_avg_range_value(
+ std::vector<OlapTuple>& begin_scan_keys, std::vector<OlapTuple>&
end_scan_keys,
+ int32_t max_scan_key_num) {
+ constexpr bool reject_type = primitive_type ==
PrimitiveType::TYPE_LARGEINT ||
+ primitive_type ==
PrimitiveType::TYPE_DECIMALV2 ||
+ primitive_type == PrimitiveType::TYPE_HLL ||
+ primitive_type == PrimitiveType::TYPE_VARCHAR
||
+ primitive_type == PrimitiveType::TYPE_CHAR ||
+ primitive_type == PrimitiveType::TYPE_STRING
||
+ primitive_type == PrimitiveType::TYPE_BOOLEAN
||
+ primitive_type ==
PrimitiveType::TYPE_DATETIME ||
+ primitive_type ==
PrimitiveType::TYPE_DATETIMEV2;
+ if constexpr (reject_type) {
Review Comment:
why largeint do not change the range?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
