morrySnow commented on code in PR #55305:
URL: https://github.com/apache/doris/pull/55305#discussion_r2485424037
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/PredicatesSplitter.java:
##########
@@ -118,7 +119,11 @@ private static boolean containOnlyColumnRef(Expression
expression, boolean allow
}
if (expression instanceof ElementAt) {
// in RBO rewrite, plan has element at expression
- return containOnlyColumnRef(((ElementAt) expression).child(0),
true);
+ return containOnlyColumnRef(expression.child(0), true);
+ }
+ if (expression instanceof StructElement) {
Review Comment:
```what will happen for other query pattern that has a['b']```
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/rules/exploration/mv/StructInfo.java:
##########
@@ -568,6 +570,9 @@ public static class PlanCheckContext {
private int topAggregateNum = 0;
private boolean alreadyMeetJoin = false;
private final Set<JoinType> supportJoinTypes;
+ private boolean containsTopGenerate = false;
+ private int topGenerateNum = 0;
+ private boolean isGenerateNeighbourCatalog = true;
Review Comment:
add comment to explain this flag
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
