zclllyybb commented on PR #57234:
URL: https://github.com/apache/doris/pull/57234#issuecomment-3447386172
> Hi @zclllyybb @yiguolei If you have time, could you please take a look at
this PR? The failing tests now pass on my local machine.
Hi @KeeProMise , thanks for your contribution! In this PR you actually
modified the logic of function `str_to_date`, right?
so,
1. could you add a stacktrace or something to explain how the functions'
behaviour of the two weird format input affects the mv? @zddr @seawinde do you
have more information?
2. `select STR_TO_DATE('202501', '%Y%m');` is also not supported by MySQL.
so I'm not sure if this fix is proper. same to the point 1, I want firstly
figure out if there's some way more directly to fix your problem.
3. if we decide to accept this patch, you should add some regression
testcases using `testFoldConst` to make sure the behaviour has no diff between
BE and FE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
