HappenLee commented on code in PR #13314:
URL: https://github.com/apache/doris/pull/13314#discussion_r995598114
##########
be/src/vec/functions/like.cpp:
##########
@@ -63,35 +63,171 @@ Status LikeSearchState::clone(LikeSearchState& cloned) {
return Status::OK();
}
-Status FunctionLikeBase::constant_starts_with_fn(LikeSearchState* state, const
StringValue& val,
+Status FunctionLikeBase::constant_starts_with_fn(LikeSearchState* state, const
ColumnString& val,
const StringValue& pattern,
- unsigned char* result) {
- *result = (val.len >= state->search_string_sv.len) &&
- (state->search_string_sv == val.substring(0,
state->search_string_sv.len));
+ ColumnUInt8::Container&
result) {
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ const auto& str_ref = val.get_data_at(i);
+ result[i] = (str_ref.size >= state->search_string_sv.size) &&
+ str_ref.start_with(state->search_string_sv);
+ }
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_ends_with_fn(LikeSearchState* state, const
ColumnString& val,
+ const StringValue& pattern,
+ ColumnUInt8::Container& result)
{
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ const auto& str_ref = val.get_data_at(i);
+ result[i] = (str_ref.size >= state->search_string_sv.size) &&
+ str_ref.end_with(state->search_string_sv);
+ }
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_equals_fn(LikeSearchState* state, const
ColumnString& val,
+ const StringValue& pattern,
+ ColumnUInt8::Container& result) {
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ result[i] = (val.get_data_at(i) == state->search_string_sv);
+ }
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_substring_fn(LikeSearchState* state, const
ColumnString& val,
+ const StringValue& pattern,
+ ColumnUInt8::Container& result)
{
+ auto sz = val.size();
+ for (size_t i = 0; i < sz; i++) {
+ if (state->search_string_sv.size == 0) {
+ result[i] = true;
+ return Status::OK();
+ }
+ result[i] = state->substring_pattern.search(val.get_data_at(i)) != -1;
+ }
return Status::OK();
}
-Status FunctionLikeBase::constant_ends_with_fn(LikeSearchState* state, const
StringValue& val,
- const StringValue& pattern,
unsigned char* result) {
- *result = (val.len >= state->search_string_sv.len) &&
- (state->search_string_sv ==
- val.substring(val.len - state->search_string_sv.len,
state->search_string_sv.len));
+Status FunctionLikeBase::constant_starts_with_fn_predicate(
+ LikeSearchState* state, const PredicateColumnType<TYPE_STRING>& val,
+ const StringValue& pattern, ColumnUInt8::Container& result, uint16_t*
sel, size_t sz) {
+ auto data_ptr = reinterpret_cast<const StringRef*>(val.get_data().data());
+ for (size_t i = 0; i < sz; i++) {
+ result[i] = (data_ptr[sel[i]].size >= state->search_string_sv.size) &&
+ (state->search_string_sv ==
+ data_ptr[sel[i]].substring(0,
state->search_string_sv.size));
+ }
return Status::OK();
}
-Status FunctionLikeBase::constant_equals_fn(LikeSearchState* state, const
StringValue& val,
- const StringValue& pattern,
unsigned char* result) {
+Status FunctionLikeBase::constant_ends_with_fn_predicate(
+ LikeSearchState* state, const PredicateColumnType<TYPE_STRING>& val,
+ const StringValue& pattern, ColumnUInt8::Container& result, uint16_t*
sel, size_t sz) {
+ auto data_ptr = reinterpret_cast<const StringRef*>(val.get_data().data());
+ for (size_t i = 0; i < sz; i++) {
+ result[i] =
+ (data_ptr[sel[i]].size >= state->search_string_sv.size) &&
+ (state->search_string_sv ==
+ data_ptr[sel[i]].substring(data_ptr[sel[i]].size -
state->search_string_sv.size,
+ state->search_string_sv.size));
+ }
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_equals_fn_predicate(LikeSearchState* state,
+ const
PredicateColumnType<TYPE_STRING>& val,
+ const StringValue&
pattern,
+ ColumnUInt8::Container&
result, uint16_t* sel,
+ size_t sz) {
+ auto data_ptr = reinterpret_cast<const StringRef*>(val.get_data().data());
+ for (size_t i = 0; i < sz; i++) {
+ result[i] = (data_ptr[sel[i]] == state->search_string_sv);
+ }
+ return Status::OK();
+}
+
+Status FunctionLikeBase::constant_substring_fn_predicate(
+ LikeSearchState* state, const PredicateColumnType<TYPE_STRING>& val,
+ const StringValue& pattern, ColumnUInt8::Container& result, uint16_t*
sel, size_t sz) {
+ auto data_ptr = reinterpret_cast<const StringRef*>(val.get_data().data());
+ for (size_t i = 0; i < sz; i++) {
+ if (state->search_string_sv.size == 0) {
+ result[i] = true;
Review Comment:
same as upper
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
