englefly commented on code in PR #57258:
URL: https://github.com/apache/doris/pull/57258#discussion_r2454108364
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/properties/ChildOutputPropertyDeriver.java:
##########
@@ -319,17 +319,15 @@ public PhysicalProperties visitPhysicalNestedLoopJoin(
return new
PhysicalProperties(leftOutputProperty.getDistributionSpec());
}
- @Override
- public PhysicalProperties visitPhysicalProject(PhysicalProject<? extends
Plan> project, PlanContext context) {
- // TODO: order spec do not process since we do not use it.
- Preconditions.checkState(childrenOutputProperties.size() == 1);
- PhysicalProperties childProperties = childrenOutputProperties.get(0);
+ public static PhysicalProperties computeProjectOutputProperties(
Review Comment:
already add regression case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
