wenzhenghu commented on code in PR #55772:
URL: https://github.com/apache/doris/pull/55772#discussion_r2450548664


##########
be/src/io/cache/block_file_cache.cpp:
##########


Review Comment:
       auto query_context = std::make_shared<QueryFileCacheContext>(
               _capacity * file_cache_query_limit_percent / 100);
   -----
   Before initializing the query limit capacity, the following checks should be 
performed:
   If the value is 0, 100, or if the query limit is not enabled, terminate the 
check early and do not proceed to the initialization process.
   Ensure it is not less than a hardcoded value or a configured value, and also 
does not exceed the total cache capacity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to