xinyiZzz commented on code in PR #13285: URL: https://github.com/apache/doris/pull/13285#discussion_r994508227
########## be/src/runtime/memory/chunk_allocator.cpp: ########## @@ -204,7 +205,7 @@ Status ChunkAllocator::allocate(size_t size, Chunk* chunk) { void ChunkAllocator::free(const Chunk& chunk) { DCHECK(chunk.core_id != -1); CHECK((chunk.size & (chunk.size - 1)) == 0); - if (config::disable_mem_pools) { + if (config::disable_chunk_allocator) { Review Comment: Is it better to move the condition into `MemPool` and rename `disable_chunk_allocator_in_mem_pool`, Similar to `disable_chunk_allocator_in_vec` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org