levy5307 commented on code in PR #13336: URL: https://github.com/apache/doris/pull/13336#discussion_r994392469
########## be/src/exec/json_scanner.h: ########## @@ -178,7 +178,15 @@ class JsonReader { std::vector<std::vector<JsonPath>> _parsed_jsonpaths; std::vector<JsonPath> _parsed_json_root; - rapidjson::Document _origin_json_doc; // origin json document object from parsed json string + char _value_buffer[4 * 1024 * 1024]; + char _parse_buffer[512 * 1024]; Review Comment: > The constant is only used here and once, so it can be directly used? I don't think so. Because we can hardly get the meaning `512*1024`, but we can get it from the name of a constant -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org