w41ter commented on code in PR #56463:
URL: https://github.com/apache/doris/pull/56463#discussion_r2385098740
##########
cloud/src/meta-store/meta_reader.cpp:
##########
@@ -553,6 +553,114 @@ TxnErrorCode
MetaReader::get_partition_versions(Transaction* txn,
return TxnErrorCode::TXN_OK;
}
+TxnErrorCode MetaReader::get_rowset_metas_by_versionstamp(
+ int64_t start_version, int64_t end_version, const Versionstamp& vs,
+ std::vector<RowsetMetaCloudPB>* rowset_metas, bool snapshot) {
+ DCHECK(txn_kv_) << "TxnKv must be set before calling";
+ if (!txn_kv_) {
+ return TxnErrorCode::TXN_INVALID_ARGUMENT;
+ }
+ std::unique_ptr<Transaction> txn;
+ TxnErrorCode err = txn_kv_->create_txn(&txn);
+ if (err != TxnErrorCode::TXN_OK) {
+ return err;
+ }
+ return get_rowset_metas_by_versionstamp(txn.get(), start_version,
end_version, vs, rowset_metas,
+ snapshot);
+}
+
+TxnErrorCode MetaReader::get_rowset_metas_by_versionstamp(
+ Transaction* txn, int64_t start_version, int64_t end_version, const
Versionstamp& vs,
Review Comment:
Could you clarify where the `vs` parameter is used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
