HappenLee commented on code in PR #13332:
URL: https://github.com/apache/doris/pull/13332#discussion_r993556849
##########
be/src/vec/columns/column_decimal.cpp:
##########
@@ -164,9 +164,21 @@ template <typename T>
void ColumnDecimal<T>::update_hashes_with_value(uint64_t* __restrict hashes,
const uint8_t* __restrict
null_data) const {
auto s = size();
- for (int i = 0; i < s; i++) {
- hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const
char*>(&data[i]), sizeof(T),
- hashes[i]);
+ if (null_data) {
+ for (int i = 0; i < s; i++) {
+ if (null_data[i] == 0) {
+ hashes[i] = HashUtil::xxHash64WithSeed(reinterpret_cast<const
char*>(&data[i]),
+ sizeof(T), hashes[i]);
+ }
+ else {
Review Comment:
here seems do not need compute again ？ just do nothing is ok ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
