Kikyou1997 commented on code in PR #13311:
URL: https://github.com/apache/doris/pull/13311#discussion_r993070844


##########
fe/fe-core/src/main/java/org/apache/doris/statistics/ColumnStat.java:
##########
@@ -285,6 +285,17 @@ private double convertToDouble(Type type, String 
columnValue) throws AnalysisExc
 
     }
 
+    private double convertStringToDouble(String s) {

Review Comment:
   I suggest that override `getLongValue` in StringLiteral, and move those 
logic to the overided method



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to