eldenmoon commented on code in PR #56382:
URL: https://github.com/apache/doris/pull/56382#discussion_r2374599292
##########
be/src/olap/rowset/segment_v2/segment.cpp:
##########
@@ -197,13 +197,15 @@ Status Segment::_open(OlapReaderStatistics* stats) {
_num_rows = footer_pb_shared->num_rows();
// An estimated memory usage of a segment
- _meta_mem_usage += footer_pb_shared->ByteSizeLong();
+ // Footer is seperated to StoragePageCache so we don't need to add it to
_meta_mem_usage
+ // _meta_mem_usage += footer_pb_shared->ByteSizeLong();
if (_pk_index_meta != nullptr) {
_meta_mem_usage += _pk_index_meta->ByteSizeLong();
}
_meta_mem_usage += sizeof(*this);
- _meta_mem_usage += _tablet_schema->num_columns() *
config::estimated_mem_per_column_reader;
+ _meta_mem_usage +=
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
