CalvinKirs commented on code in PR #56579:
URL: https://github.com/apache/doris/pull/56579#discussion_r2386610544
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/AbstractS3CompatibleProperties.java:
##########
@@ -264,8 +254,12 @@ public void initializeHadoopStorageConfig() {
private void appendS3HdfsProperties(Configuration hadoopStorageConfig) {
hadoopStorageConfig.set("fs.s3.impl",
"org.apache.hadoop.fs.s3a.S3AFileSystem");
hadoopStorageConfig.set("fs.s3a.impl",
"org.apache.hadoop.fs.s3a.S3AFileSystem");
- hadoopStorageConfig.set("fs.s3a.endpoint", getEndpoint());
- hadoopStorageConfig.set("fs.s3a.endpoint.region", getRegion());
+ if (StringUtils.isNotBlank(getEndpoint())) {
+ hadoopStorageConfig.set("fs.s3a.endpoint", getEndpoint());
+ }
+ if (StringUtils.isNotBlank(getRegion())) {
Review Comment:
We need to transform non-standard endpoints, such as Delta Lake.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/AbstractS3CompatibleProperties.java:
##########
@@ -264,8 +254,12 @@ public void initializeHadoopStorageConfig() {
private void appendS3HdfsProperties(Configuration hadoopStorageConfig) {
hadoopStorageConfig.set("fs.s3.impl",
"org.apache.hadoop.fs.s3a.S3AFileSystem");
hadoopStorageConfig.set("fs.s3a.impl",
"org.apache.hadoop.fs.s3a.S3AFileSystem");
- hadoopStorageConfig.set("fs.s3a.endpoint", getEndpoint());
- hadoopStorageConfig.set("fs.s3a.endpoint.region", getRegion());
+ if (StringUtils.isNotBlank(getEndpoint())) {
+ hadoopStorageConfig.set("fs.s3a.endpoint", getEndpoint());
+ }
+ if (StringUtils.isNotBlank(getRegion())) {
Review Comment:
We need to transform non-standard endpoints, such as Delta Lake.
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/property/storage/OSSProperties.java:
##########
@@ -247,7 +249,7 @@ protected void setEndpointIfPossible() {
@Override
public void initNormalizeAndCheckProps() {
super.initNormalizeAndCheckProps();
- if (endpoint.contains("dlf") || endpoint.contains("oss-dls")) {
+ if (StringUtils.isBlank(endpoint) ||
!STANDARD_ENDPOINT_PATTERN.matcher(endpoint).matches()) {
Review Comment:
We need to transform non-standard endpoints, such as Delta Lake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
