wenzhenghu commented on code in PR #55772:
URL: https://github.com/apache/doris/pull/55772#discussion_r2386474429
##########
gensrc/thrift/PaloInternalService.thrift:
##########
@@ -408,6 +408,7 @@ struct TQueryOptions {
// In write path, to control if the content would be written into file cache.
// In read path, read from file cache or remote storage when execute query.
1000: optional bool disable_file_cache = false
+ 1001: optional bool enable_file_cache_query_limit = true
Review Comment:
正宇，我想过把file_cache_query_limit_bytes做成session变量，我又考虑到如果让用户设置，用户大概率是考虑利己的而不是利他的，他们会追求高性能而把限制设置得很大，那这个功能就废了。当然，暴露enable_file_cache_query_limit也有类似问题，用户如果知道有这个功能，他们可能会把这个参数设置成false。所以，我想过后续再基于sql类型或设置用户白名单之类的方式来解决这个问题。针对这个顾虑，正宇有什么建议吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
