eldenmoon commented on code in PR #56977:
URL: https://github.com/apache/doris/pull/56977#discussion_r2434909187
##########
be/src/vec/data_types/serde/data_type_serde.cpp:
##########
@@ -134,5 +138,230 @@ void DataTypeSerDe::to_string(const IColumn& column,
size_t row_num, BufferWrita
const std::string DataTypeSerDe::NULL_IN_COMPLEX_TYPE = "null";
const std::string DataTypeSerDe::NULL_IN_CSV_FOR_ORDINARY_TYPE = "\\N";
+const uint8_t* DataTypeSerDe::deserialize_binary_to_column(const uint8_t*
data, IColumn& column) {
+ auto& nullable_column = assert_cast<ColumnNullable&,
TypeCheckOnRelease::DISABLE>(column);
+ const FieldType type = static_cast<FieldType>(*data++);
+ const uint8_t* end = data;
+ switch (type) {
+ case FieldType::OLAP_FIELD_TYPE_STRING: {
Review Comment:
直接在Subcolumn缓存serde？是否能避免这一堆switch case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
