zclllyybb commented on code in PR #56915:
URL: https://github.com/apache/doris/pull/56915#discussion_r2438304831
##########
be/src/vec/functions/date_time_transforms.h:
##########
@@ -210,8 +212,9 @@ struct MonthNameImpl {
static constexpr auto max_size = MAX_MONTH_NAME_LEN;
static auto execute(const typename PrimitiveTypeTraits<PType>::CppType& dt,
- ColumnString::Chars& res_data, size_t& offset) {
- const auto* month_name = dt.month_name();
+ ColumnString::Chars& res_data, size_t& offset,
+ const std::string& locale_name) {
+ const auto* month_name = dt.month_name_with_locale(locale_name);
Review Comment:
这个session variable必然是个常量，在 open 里面可以直接提取出来，然后拿到结果数组。这样就不用每一行执行的时候都去获取了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
