wumeibanfa commented on code in PR #56441:
URL: https://github.com/apache/doris/pull/56441#discussion_r2423376991
##########
be/src/olap/rowset/segment_v2/page_io.cpp:
##########
@@ -124,8 +124,8 @@ std::string file_cache_key_str(const std::string& seg_path)
{
return file_cache_key_from_path(seg_path).to_string();
}
-Status PageIO::read_and_decompress_page_(const PageReadOptions& opts,
PageHandle* handle,
- Slice* body, PageFooterPB* footer) {
+Status PageIO::read_and_decompress_page_(PageReadOptions& opts, PageHandle*
handle, Slice* body,
Review Comment:
Sorry, there are some issues here. I will modify them
##########
be/src/olap/rowset/segment_creator.cpp:
##########
@@ -384,7 +382,7 @@ SegmentCreator::SegmentCreator(RowsetWriterContext&
context, SegmentFileCollecti
InvertedIndexFileCollection& idx_files)
: _segment_flusher(context, seg_files, idx_files) {}
-Status SegmentCreator::add_block(const vectorized::Block* block) {
Review Comment:
Sorry, there are some issues here. I will modify them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
