[GitHub] [doris] xinyiZzz commented on a diff in pull request #10170: [Enhancement](optimizer) Support select table sample

[GitBox]

xinyiZzz commented on code in PR #10170:
URL: https://github.com/apache/doris/pull/10170#discussion_r990641601


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/TableRef.java:
##########
@@ -160,6 +161,12 @@ public TableRef(TableName name, String alias, 
PartitionNames partitionNames, Arr
             hasExplicitAlias = false;
         }
         this.partitionNames = partitionNames;
+        if (sampleTabletIds != null) {
+            this.sampleTabletIds = sampleTabletIds;
+        }
+        if (tableSample != null) {

Review Comment:
   No, such as `SELECT * FROM t1 TABLET(10001) limit 1000;`, tableSample is null
   
![image](https://user-images.githubusercontent.com/13197424/194709585-61637b2d-1e8d-4bae-ba6c-b5119b8d724d.png)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org