924060929 commented on code in PR #56691:
URL: https://github.com/apache/doris/pull/56691#discussion_r2435409415
##########
fe/fe-core/src/main/antlr4/org/apache/doris/nereids/DorisParser.g4:
##########
@@ -1605,6 +1605,8 @@ primaryExpression
(ORDER BY sortItem (COMMA sortItem)*)?
(SEPARATOR sep=expression)? RIGHT_PAREN
(OVER windowSpec)?
#groupConcat
+ | GET_FORMAT LEFT_PAREN
Review Comment:
missing GET_FORMAT in nonReserved and DorisLexer.g4
##########
fe/fe-core/src/main/java/org/apache/doris/catalog/BuiltinScalarFunctions.java:
##########
@@ -1061,7 +1062,8 @@ public class BuiltinScalarFunctions implements
FunctionHelper {
scalar(Embed.class, "embed"),
scalar(Uniform.class, "uniform"),
scalar(MakeSet.class, "make_set"),
- scalar(ExportSet.class, "export_set"));
+ scalar(ExportSet.class, "export_set"),
+ scalar(GetFormat.class, "get_format"));
Review Comment:
place by the lexicographical order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
