gavinchou opened a new pull request, #13133:
URL: https://github.com/apache/doris/pull/13133

   The key keyword definition section of `sql_parser.cup` is unordered and 
messy:
   1. It is almost unreadable
   2. There are no rules to format it when we make a change to it
   3. **It takes unnecessary effort to resolve conflict caused by the unordered 
keywords**
   
   We can apply some simple rules to format it:
   1. Sort in lexicographical order
   4. Break into several "sections", keywords in each section have the same 
prefix `KW_${first_letter}`
   5. Every 2 sections are connected with an empty line containing only 4 white 
spaces
   
   e.g.
   
   ```
   terminal String
       KW_A...
   
       KW_B...
   
       ...
   
       KW_Z...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to