HappenLee commented on code in PR #13024:
URL: https://github.com/apache/doris/pull/13024#discussion_r982487067
##########
be/src/exprs/bloomfilter_predicate.h:
##########
@@ -244,9 +244,13 @@ struct DateV2FindOp
bool find_olap_engine(const BloomFilterAdaptor& bloom_filter, const void*
data) const {
doris::vectorized::DateV2Value<doris::vectorized::DateV2ValueType>
value;
value.from_date(*reinterpret_cast<const uint32_t*>(data));
- return bloom_filter.test(
- Slice((char*)&value,
-
sizeof(doris::vectorized::DateV2Value<doris::vectorized::DateV2ValueType>)));
+
+ uint64_t datetime_value =
+ ((uint64_t)binary_cast<
Review Comment:
the logic is confuse. maybe we should not allow do date cast to datetime in
v2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
