Mryange opened a new pull request, #55822:
URL: https://github.com/apache/doris/pull/55822
### What problem does this PR solve?
Previously, some functions had incorrect checks for input values that were
out of range.
For example, for NaN, its comparison with other floating-point numbers is
indeterminate.
The constant folding in FE is also different.
In addition, the documentation for these functions has been updated.
before
```
mysql> set debug_skip_fold_constant = false;
Query OK, 0 rows affected (0.01 sec)
mysql> select acos(cast('nan' as double)), acos(cast('inf' as double)),
acos(cast('-inf' as double)), acos(cast('0.0' as double)), acos(cast('1.0' as
double)), acos(cast('-1.0' as double)), acos(cast('1.0000001' as double)),
acos(cast('-1.0000001' as double)) \G;
*************************** 1. row ***************************
acos(cast('nan' as double)): NULL
acos(cast('inf' as double)): NULL
acos(cast('-inf' as double)): NULL
acos(cast('0.0' as double)): 1.570796326794897
acos(cast('1.0' as double)): 0
acos(cast('-1.0' as double)): 3.141592653589793
acos(cast('1.0000001' as double)): NULL
acos(cast('-1.0000001' as double)): NULL
1 row in set (0.01 sec)
mysql> set debug_skip_fold_constant = true;
Query OK, 0 rows affected (0.00 sec)
mysql> select acos(cast('nan' as double)), acos(cast('inf' as double)),
acos(cast('-inf' as double)), acos(cast('0.0' as double)), acos(cast('1.0' as
double)), acos(cast('-1.0' as double)), acos(cast('1.0000001' as double)),
acos(cast('-1.0000001' as double)) \G;
*************************** 1. row ***************************
acos(cast('nan' as double)): NaN
acos(cast('inf' as double)): NULL
acos(cast('-inf' as double)): NULL
acos(cast('0.0' as double)): 1.570796326794897
acos(cast('1.0' as double)): 0
acos(cast('-1.0' as double)): 3.141592653589793
acos(cast('1.0000001' as double)): NULL
acos(cast('-1.0000001' as double)): NULL
1 row in set (0.07 sec)
```
now
```
mysql> set debug_skip_fold_constant = false;
Query OK, 0 rows affected (0.00 sec)
mysql> select acos(cast('nan' as double)), acos(cast('inf' as double)),
acos(cast('-inf' as double)), acos(cast('0.0' as double)), acos(cast('1.0' as
double)), acos(cast('-1.0' as double)), acos(cast('1.0000001' as double)),
acos(cast('-1.0000001' as double)) \G;
*************************** 1. row ***************************
acos(cast('nan' as double)): NaN
acos(cast('inf' as double)): NULL
acos(cast('-inf' as double)): NULL
acos(cast('0.0' as double)): 1.570796326794897
acos(cast('1.0' as double)): 0
acos(cast('-1.0' as double)): 3.141592653589793
acos(cast('1.0000001' as double)): NULL
acos(cast('-1.0000001' as double)): NULL
1 row in set (0.00 sec)
mysql> set debug_skip_fold_constant = true;
Query OK, 0 rows affected (0.00 sec)
mysql> select acos(cast('nan' as double)), acos(cast('inf' as double)),
acos(cast('-inf' as double)), acos(cast('0.0' as double)), acos(cast('1.0' as
double)), acos(cast('-1.0' as double)), acos(cast('1.0000001' as double)),
acos(cast('-1.0000001' as double)) \G;
*************************** 1. row ***************************
acos(cast('nan' as double)): NaN
acos(cast('inf' as double)): NULL
acos(cast('-inf' as double)): NULL
acos(cast('0.0' as double)): 1.570796326794897
acos(cast('1.0' as double)): 0
acos(cast('-1.0' as double)): 3.141592653589793
acos(cast('1.0000001' as double)): NULL
acos(cast('-1.0000001' as double)): NULL
1 row in set (0.05 sec)
```
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
