dataroaring commented on code in PR #56175:
URL: https://github.com/apache/doris/pull/56175#discussion_r2357471817
##########
cloud/src/meta-service/meta_service_txn.cpp:
##########
@@ -610,6 +610,75 @@ void put_routine_load_progress(MetaServiceCode& code,
std::string& msg,
<< " routine load new progress: " <<
new_progress_info.ShortDebugString();
}
+void put_streaming_job_meta(MetaServiceCode& code, std::string& msg, const
std::string& instance_id,
+ const CommitTxnRequest* request, Transaction* txn,
int64_t db_id) {
+ std::stringstream ss;
+ int64_t txn_id = request->txn_id();
+ if (!request->has_commit_attachment()) {
+ ss << "failed to get commit attachment from req, db_id=" << db_id << "
txn_id=" << txn_id;
+ msg = ss.str();
Review Comment:
code is not set. we can define a marco setting both msg and code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
