Copilot commented on code in PR #56070:
URL: https://github.com/apache/doris/pull/56070#discussion_r2351763221
##########
be/src/vec/runtime/vdatetime_value.h:
##########
@@ -508,6 +508,7 @@ class VecDateTimeValue { // Now this type is a temp
solution with little changes
uint8_t hour() const { return _hour; }
uint8_t minute() const { return _minute; }
uint16_t second() const { return _second; }
+ uint8_t microsecond() const { return 0; }
Review Comment:
The microsecond() method always returns 0, which doesn't provide actual
microsecond values. This could lead to incorrect behavior when microsecond
precision is needed for calculations.
```suggestion
uint32_t microsecond() const { return _microsecond; }
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
