BiteTheDDDDt commented on code in PR #55719:
URL: https://github.com/apache/doris/pull/55719#discussion_r2347811711
##########
be/src/vec/aggregate_functions/aggregate_function.h:
##########
@@ -131,27 +131,25 @@ class IAggregateFunction {
std::vector<int>& rows, Arena&) const {}
/// Merges state (on which place points to) with other state of current
aggregation function.
- virtual void merge(AggregateDataPtr __restrict place,
ConstAggregateDataPtr rhs,
- Arena&) const = 0;
+ virtual void merge(AggregateDataPtr __restrict place, AggregateDataPtr
rhs, Arena&) const = 0;
Review Comment:
这块先别这样改吧，这两个都不是正规函数，得从函数本身入手修改
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
