morningman commented on code in PR #12904:
URL: https://github.com/apache/doris/pull/12904#discussion_r978272759
##########
fe_plugins/auditloader/src/main/java/org/apache/doris/plugin/audit/AuditLoaderPlugin.java:
##########
@@ -134,12 +134,12 @@ public boolean eventFilter(AuditEvent.EventType type) {
public void exec(AuditEvent event) {
try {
- auditEventQueue.add(event);
+ auditEventQueue.put(event);
Review Comment:
This will block if queue is full, which may block the FE core
##########
fe_plugins/auditloader/src/main/java/org/apache/doris/plugin/audit/AuditLoaderPlugin.java:
##########
@@ -134,12 +134,12 @@ public boolean eventFilter(AuditEvent.EventType type) {
public void exec(AuditEvent event) {
try {
- auditEventQueue.add(event);
+ auditEventQueue.put(event);
} catch (Exception e) {
// In order to ensure that the system can run normally, here we
directly
// discard the current audit_event. If this problem occurs
frequently,
// improvement can be considered.
- LOG.debug("encounter exception when putting current audit batch,
discard current audit event", e);
+ LOG.error("encounter exception when putting current audit batch,
discard current audit event", e);
Review Comment:
use warn?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org
