liaoxin01 commented on code in PR #12875: URL: https://github.com/apache/doris/pull/12875#discussion_r978212087
########## be/src/olap/rowset/beta_rowset_writer.h: ########## @@ -69,6 +69,7 @@ class BetaRowsetWriter : public RowsetWriter { RowsetTypePB type() const override { return RowsetTypePB::BETA_ROWSET; } Status get_segment_num_rows(std::vector<uint32_t>* segment_num_rows) const override { + std::shared_lock l(_lock); Review Comment: use lock_guard or change `_lock` to shared_mutex? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org For additional commands, e-mail: commits-h...@doris.apache.org