wumeibanfa commented on code in PR #55719:
URL: https://github.com/apache/doris/pull/55719#discussion_r2343051170
##########
be/src/vec/columns/column_variant.cpp:
##########
@@ -1428,6 +1428,9 @@ const ColumnVariant::Subcolumn*
ColumnVariant::get_subcolumn_with_cache(const Pa
}
ColumnVariant::Subcolumn* ColumnVariant::get_subcolumn(const PathInData& key,
size_t key_index) {
+ // Since the cache stores const types, non-const versions cannot be used.
const_cast must be employed to
+ // eliminate const semantics. As all nodes are created via
std::make_shared<Node>, modifying them will
+ // not result in uninitialized behavior
Review Comment:
get_subcolumn_with_cache需要用到一个cache，const 方法返回const T*, non-cont方法返回 T *,
但是这个cache只有一个，不能同时存储T 和const T
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
