stalary commented on code in PR #12824:
URL: https://github.com/apache/doris/pull/12824#discussion_r977109766


##########
fe/fe-core/src/main/java/org/apache/doris/service/FrontendServiceImpl.java:
##########
@@ -501,6 +501,11 @@ public TMasterOpResult forward(TMasterOpRequest params) 
throws TException {
         context.setCurrentConnectedFEIp(clientAddr.getHostname());
         ConnectProcessor processor = new ConnectProcessor(context);
         TMasterOpResult result = processor.proxyExecute(params);
+        if ("ERR".equalsIgnoreCase(result.getStatus())) {

Review Comment:
   ```suggestion
           if 
(QueryState.MysqlStateType.ERR.equalsIgnoreCase(result.getStatus())) {
   ```



##########
fe/fe-core/src/main/java/org/apache/doris/qe/MasterOpExecutor.java:
##########
@@ -165,6 +165,16 @@ public TUniqueId getQueryId() {
         }
     }
 
+    public String getProxyStatus() {
+        if (result == null) {
+            return QueryState.MysqlStateType.UNKNOWN.name();
+        }
+        if (result.isSetStatus()) {

Review Comment:
   Is it supposed to be `!result.isSetStatus()`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org

Reply via email to