englefly commented on code in PR #55883:
URL: https://github.com/apache/doris/pull/55883#discussion_r2338337090
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/processor/post/materialize/MaterializeProbeVisitor.java:
##########
@@ -119,10 +120,18 @@ boolean
checkTVFRelationTableSupportedType(PhysicalTVFRelation tvfRelation) {
@Override
public Optional<MaterializeSource> visitPhysicalOlapScan(PhysicalOlapScan
scan, ProbeContext context) {
- if (scan.getSelectedIndexId() == scan.getTable().getBaseIndexId()) {
- return visitPhysicalCatalogRelation(scan, context);
+ if (scan.getSelectedIndexId() != scan.getTable().getBaseIndexId()) {
+ return Optional.empty();
}
- return Optional.empty();
+ // agg table do not support lazy materialize
+ OlapTable table = scan.getTable();
+ if (KeysType.AGG_KEYS.equals(table.getKeysType())) {
+ return Optional.empty();
+ }
+ if (scan.getOperativeSlots().contains(context.slot)) {
+ return Optional.empty();
Review Comment:
mor key columns are in scan.operativeSlots. mor value columns can be lazy
materialized.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]