SWJTU-ZhangLei commented on code in PR #54694:
URL: https://github.com/apache/doris/pull/54694#discussion_r2331862382
##########
be/src/cloud/cloud_base_compaction.cpp:
##########
@@ -38,6 +38,12 @@ bvar::Adder<uint64_t> base_output_size("base_compaction",
"output_size");
bvar::LatencyRecorder g_base_compaction_hold_delete_bitmap_lock_time_ms(
"base_compaction_hold_delete_bitmap_lock_time_ms");
+bvar::Status<double> base_compaction_input_rowsets_data_hit_cache_ratio(
+ "base_compaction_input_rowsets_data_hit_cache_ratio", 0.0);
Review Comment:
> 这个ratio是某一次做base compaction的ratio, 没有意义. 用bvar adder 统计累计值(从BE启动开始)
多少从cache里读了 以及 base compaction 总共读了多少数据 来统计
done，改成tablet统计所有input rowsets历史的cache_size / total_size
##########
be/src/cloud/cloud_base_compaction.cpp:
##########
@@ -91,7 +99,23 @@ Status CloudBaseCompaction::prepare_compact() {
.tag("input_segments", _input_segments)
.tag("input_rowsets_data_size", _input_rowsets_data_size)
.tag("input_rowsets_index_size", _input_rowsets_index_size)
- .tag("input_rowsets_total_size", _input_rowsets_total_size);
+ .tag("input_rowsets_total_size", _input_rowsets_total_size)
+ .tag("input_rowsets_cache_data_size",
_input_rowsets_cache_data_size)
+ .tag("input_rowsets_cache_index_size",
_input_rowsets_cache_index_size);
+
+ if (_input_rowsets_data_size > 0) {
+ base_compaction_input_rowsets_data_hit_cache_ratio.set_value(
Review Comment:
> 这个统计没有意义
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
