zgxme commented on code in PR #55734: URL: https://github.com/apache/doris/pull/55734#discussion_r2329023799
########## docker/thirdparties/custom_settings.env: ########## @@ -21,5 +21,5 @@ # eg: CONTAINER_UID="doris-jack-" # NOTICE: change this uid will modify the file in docker-compose. CONTAINER_UID="doris--" -s3Endpoint="oss-cn-hongkong.aliyuncs.com" -s3BucketName="doris-regression-hk" +export s3Endpoint="oss-cn-hongkong.aliyuncs.com" Review Comment: 比现在sed -i 直接修改脚本里endpoint 可维护性好 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
