0AyanamiRei opened a new pull request, #55750:
URL: https://github.com/apache/doris/pull/55750
### What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
This PR fixes a bug in `RowsetBuilder::check_tablet_version_count` where the
TOO_MANY_VERSION error was not triggered due to being masked by the memory
limit check. In the original logic, if the tablet version count did not exceed
`max_version_config - 100` or the memory usage exceeded the soft limit
(`GlobalMemoryArbitrator::is_exceed_soft_mem_limit`), the method returned
`Status::OK()` prematurely, bypassing the version count check against
max_tablet_version_num. This caused the TOO_MANY_VERSION error to be
suppressed, leading to incorrect behavior in version limit enforcement and
failing regression tests (e.g., too_many_versions_detection). The fix reorders
the logic to prioritize the version count check, ensuring TOO_MANY_VERSION is
triggered when version_count > max_tablet_version_num. Additionally, a new
FETCH_MEMORY_EXCEEDED error is introduced for memory shortage cases to improve
error clarity.
### Release note
None
### Check List (For Author)
- Test <!-- At least one of them must be included. -->
- [ ] Regression test
- [ ] Unit Test
- [ ] Manual test (add detailed scripts or steps below)
- [ ] No need to test or manual test. Explain why:
- [ ] This is a refactor/code format and no logic has been changed.
- [ ] Previous test can cover this change.
- [ ] No code files have been changed.
- [ ] Other reason <!-- Add your reason? -->
- Behavior changed:
- [ ] No.
- [ ] Yes. <!-- Explain the behavior change -->
- Does this need documentation?
- [ ] No.
- [ ] Yes. <!-- Add document PR link here. eg:
https://github.com/apache/doris-website/pull/1214 -->
### Check List (For Reviewer who merge this PR)
- [ ] Confirm the release note
- [ ] Confirm test cases
- [ ] Confirm document
- [ ] Add branch pick label <!-- Add branch pick label that this PR should
merge into -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
