linrrzqqq commented on code in PR #55731: URL: https://github.com/apache/doris/pull/55731#discussion_r2328494504
########## be/src/vec/functions/function_soundex.cpp: ########## @@ -0,0 +1,119 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#include <cctype> + +#include "common/status.h" +#include "vec/columns/column_string.h" +#include "vec/data_types/data_type_string.h" +#include "vec/functions/function.h" +#include "vec/functions/simple_function_factory.h" + +namespace doris::vectorized { +#include "common/compile_check_begin.h" + +class FunctionSoundex : public IFunction { +public: + static constexpr auto name = "soundex"; + + static FunctionPtr create() { return std::make_shared<FunctionSoundex>(); } + + String get_name() const override { return name; } + + size_t get_number_of_arguments() const override { return 1; } + + DataTypePtr get_return_type_impl(const DataTypes& arguments) const override { + return std::make_shared<DataTypeString>(); + } + + Status execute_impl(FunctionContext* context, Block& block, const ColumnNumbers& arguments, + uint32_t result, size_t input_rows_count) const override { + const ColumnPtr col_ptr = block.get_by_position(arguments[0]).column; + + auto res_column = ColumnString::create(); + for (size_t i = 0; i < input_rows_count; ++i) { + StringRef ref = col_ptr->get_data_at(i); + std::string soundex_code = calculate_soundex(ref); + res_column->insert_data(soundex_code.c_str(), soundex_code.length()); + } + + block.replace_by_position(result, std::move(res_column)); + return Status::OK(); + } + +private: + std::string calculate_soundex(const StringRef& ref) const { + if (ref.empty()) { + return ""; + } + + std::string result; + result.reserve(4); + char pre_code = '\0'; + for (size_t i = 0; i < ref.size; ++i) { + auto c = static_cast<unsigned char>(ref.data[i]); + + if (c > 0x7f) { + throw Exception(ErrorCode::INVALID_ARGUMENT, "soundex only supports ASCII"); + } + if (!std::isalpha(c)) { + continue; + } + + c = static_cast<char>(std::toupper(c)); + if (result.empty()) { + result += c; + pre_code = (SOUNDEX_TABLE[c - 'A'] == 'N') ? '\0' : SOUNDEX_TABLE[c - 'A']; Review Comment: I think chars in these two ranges will be filtered out by the `std::isalpha(c)` check in L73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
