[GitHub] [doris] pengxiangyu commented on a diff in pull request #12730: [Refactor](parquet) refactor parquet write to uniform and consistent logic

[GitBox]

pengxiangyu commented on code in PR #12730:
URL: https://github.com/apache/doris/pull/12730#discussion_r975038722


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/OutFileClause.java:
##########
@@ -118,12 +134,21 @@ public class OutFileClause {
     // If set to true, the brokerDesc must be null.
     private boolean isLocalOutput = false;
     private String successFileName = "";
-    private List<List<String>> schema = new ArrayList<>();
-    private Map<String, String> fileProperties = new HashMap<>();
+
+    private List<TParquetRepetitionType> schemasRepetitionType = new 
ArrayList<>();
+    private List<TParquetDataType> schemasDataType = new ArrayList<>();
+    private List<String> schemasColumnName = new ArrayList<>();

Review Comment:
   schemasRepetitionType   schemasDataType   schemasColumnName  should be set 
in a struct, or else maybe cause some bug if the index is error.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@doris.apache.org
For additional commands, e-mail: commits-h...@doris.apache.org