gavinchou commented on code in PR #55630:
URL: https://github.com/apache/doris/pull/55630#discussion_r2320691969
##########
cloud/src/meta-service/meta_service.cpp:
##########
@@ -3076,8 +3084,11 @@ void
MetaServiceImpl::get_rowset(::google::protobuf::RpcController* controller,
LOG(WARNING) << msg;
return;
}
+ bool full_compaction_cnt_changed =
+ (request->has_full_compaction_cnt() &&
tablet_stat.has_full_compaction_cnt() &&
+ request->full_compaction_cnt() <
tablet_stat.full_compaction_cnt());
auto versions = calc_sync_versions(req_bc_cnt, bc_cnt, req_cc_cnt,
cc_cnt, req_cp, cp,
- req_start, req_end);
+ req_start, req_end,
full_compaction_cnt_changed);
Review Comment:
这里参数逻辑改成 和其他的 cnt 一样, 让函数内部去做判断
req_bc_cnt, bc_cnt
req_cc_cnt, cc_cnt
req_fc_cnt, fc_cnt
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
